[build] Fix for #4326 -- GitHub Action VMs running MacOS are unreliable. #4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4326.
With this change, the parse step is bypassed for MacOS. The bnf grammar was updated to test the PR.
Unfortunately, this won't fix the spurious hangs of the MacOS runners that we see. Google has a problem with the runner code and/or is using too few servers, or is using the slowest servers on the planet. However, bypassing the MacOS tester is a small price to pay to increase the chance for the tests to be completed in a reasonable amount of time. We need a compilation and link for C++ under the MacOS environment because it is the rate-limiting factor in the code we write for the C++ target.
Just yesterday, in antlr/antlr4, a PR was submitted in which 39 runners completed in a minute or two on Windows and Ubuntu. However, the PR sat around for a MacOS test to complete in 1h 25m, with the setup of PHP taking the majority of the time at 1h 23m!